Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version details to Windows executables #473

Closed
atc0005 opened this issue Feb 2, 2023 · 0 comments · Fixed by #487
Closed

Add version details to Windows executables #473

atc0005 opened this issue Feb 2, 2023 · 0 comments · Fixed by #487
Assignees
Labels
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 2, 2023

Use github.com/tc-hib/go-winres and winres.json file to apply version details to Windows executables provided by this project.

See also:

@atc0005 atc0005 added enhancement New feature or request dependencies builds labels Feb 2, 2023
@atc0005 atc0005 added this to the Next Release milestone Feb 2, 2023
@atc0005 atc0005 self-assigned this Feb 2, 2023
atc0005 added a commit that referenced this issue Feb 8, 2023
Use tc-hib/go-winres and JSON config files to embed metadata
(e.g., version, description) into Windows executables via
`go generate`.

Related changes:

- add winres.json files to provide metadata to be embedded
  into generated Windows executables
- add `go generate` directives to main.go files
- add dependabot/tools entry for tc-hib/go-winres
- add .gitignore entry for .syso files created by
  tc-hib/go-winres
- Update Makefile build recipes to run `go generate` for
  Windows builds

refs GH-473
atc0005 added a commit that referenced this issue Feb 8, 2023
Use tc-hib/go-winres and JSON config files to embed metadata
(e.g., version, description) into Windows executables via
`go generate`.

Related changes:

- add winres.json files to provide metadata to be embedded
  into generated Windows executables
- add `go generate` directives to main.go files
- add dependabot/tools entry for tc-hib/go-winres
- add .gitignore entry for .syso files created by
  tc-hib/go-winres
- Update Makefile build recipes to run `go generate` for
  Windows builds
- Update GHAW to indicate to shared/imported workflow that
  gogeninstall Makefile recipe is needed for builds

refs GH-473
atc0005 added a commit that referenced this issue Feb 24, 2023
Now that we're using a standardized build image (containing
all relevant build dependencies), we no longer benefit from
tracking project-specific build dependencies via Dependabot
PRs (which were only ever about reminding me to update
local build environments).

refs GH-473
refs GH-506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant