Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build dev/stable releases using go-ci Docker image #506

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Feb 22, 2023

  • add dependabot/docker/builds/Dockerfile
    • to track atc0005/go-ci image releases
    • used to build temporary/local "builder" image
  • update Dependabot configuration to monitor new "builder" Dockerfile for image updates
  • update Makefile to provide new Docker-based recipes to build "dev" and "stable" releases

NOTE: Updated existing Makefile recipes to replace the PWD env variable reference with the PROJECT_DIR Makefile variable. Before this change those recipes failed to work properly when executed within a Docker container.

@atc0005 atc0005 added enhancement New feature or request dependencies builds packages Related to generated packages for this project (e.g., RPM, DEB) labels Feb 22, 2023
@atc0005 atc0005 added this to the v0.11.2 milestone Feb 22, 2023
@atc0005 atc0005 self-assigned this Feb 22, 2023
- add dependabot/docker/builds/Dockerfile
  - to track atc0005/go-ci image releases
  - used to build temporary/local "builder" image
- update Dependabot configuration to monitor new
  "builder" Dockerfile for image updates
- update Makefile to provide new Docker-based
  recipes to build "dev" and "stable" releases

NOTE: Updated existing Makefile recipes to replace
the PWD env variable reference with the PROJECT_DIR
Makefile variable. Before this change those recipes
failed to work properly when executed within a Docker
container.
@atc0005 atc0005 force-pushed the use-docker-and-go-ci-images-for-release-builds branch from b8b1291 to ed87987 Compare February 22, 2023 11:05
@atc0005 atc0005 merged commit b8563de into master Feb 22, 2023
@atc0005 atc0005 deleted the use-docker-and-go-ci-images-for-release-builds branch February 22, 2023 11:06
atc0005 added a commit that referenced this pull request Feb 24, 2023
Now that we're using a standardized build image (containing
all relevant build dependencies), we no longer benefit from
tracking project-specific build dependencies via Dependabot
PRs (which were only ever about reminding me to update
local build environments).

refs GH-473
refs GH-506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds dependencies enhancement New feature or request packages Related to generated packages for this project (e.g., RPM, DEB)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant