Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker-based GitHub Actions Workflows #76

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Jul 30, 2020

Changes

In short: Replace native GitHub Actions with containers created and managed through the atc0005/go-ci project.

This results in three workflows:

  • New, primary workflow

    • with parallel linting, testing and building tasks
    • with three Go environments
      • "old stable" - currently Go 1.13.14
      • "stable" - currently Go 1.14.6
      • "unstable" - currently Go 1.15rc1
    • Makefile is not used in this workflow
    • staticcheck linting using latest stable version
      provided by the atc0005/go-ci containers
  • Separate Makefile-based linting and building workflow

    • intended to help ensure that local Makefile-based
      builds that are referenced in project README files
      continue to work as advertised until a better local
      tool can be discovered/explored further
    • use golang:latest container to allow for Makefile-based
      linting tooling installation testing since the
      atc0005/go-ci project provides containers with those
      tools already pre-installed
  • Add Quick Validation workflow

    • run on every push, everything else on pull request updates
    • linting and testing, no builds

Other changes:

  • Makefile lintinstall recipe installs the very latest
    stable version of the golangci-lint binary instead
    of locking a specific version

    • this should reduce dependency "gardening"
  • Enabled additional golangci-lint linters (explicitly)

    • govet
    • statccheck
  • Disable exclude-use-default setting to enable various
    warnings that are muted by default

References

@atc0005 atc0005 added this to the v0.3.0 milestone Jul 30, 2020
@atc0005 atc0005 self-assigned this Jul 30, 2020
@atc0005 atc0005 force-pushed the i75-add-container-based-ci-workflow branch from 9a7fd87 to ddfb9ee Compare July 30, 2020 22:22
@atc0005
Copy link
Owner Author

atc0005 commented Jul 30, 2020

Linting failures are triggered due to the same setting that I've explicitly enabled here as in GH-72. Will rebase this branch once that associated branch goes in.

Replace native GitHub Actions with containers created
and managed through the `atc0005/go-ci` project.

This results in three workflows:

- New, primary workflow
  - with parallel linting, testing and building tasks
  - with three Go environments
    - "old stable" - currently `Go 1.13.14`
    - "stable" - currently `Go 1.14.6`
    - "unstable" - currently `Go 1.15rc1`
  - Makefile is *not* used in this workflow
  - staticcheck linting using latest stable version
    provided by the `atc0005/go-ci` containers

- Separate Makefile-based linting and building workflow
  - intended to help ensure that local Makefile-based
    builds that are referenced in project README files
    continue to work as advertised until a better local
    tool can be discovered/explored further
  - use `golang:latest` container to allow for Makefile-based
    linting tooling installation testing since the
    `atc0005/go-ci` project provides containers with those
    tools already pre-installed

- Add Quick Validation workflow
  - run on every push, everything else on pull request updates
  - linting via `golangci-lint` only
  - testing
  - no builds

Other changes:

- Makefile `lintinstall` recipe installs the very latest
  stable version of the `golangci-lint` binary instead
  of locking a specific version
  - this should reduce dependency "gardening"

- Enabled additional golangci-lint linters (explicitly)
  - `govet`
  - `statccheck`

refs GH-75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Test alternate container-based CI GitHub Actions workflows
1 participant