Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand linting GitHub Actions Workflow to include oldstable, unstable container images #375

Closed
atc0005 opened this issue Feb 4, 2022 · 0 comments · Fixed by #376
Closed

Expand linting GitHub Actions Workflow to include oldstable, unstable container images #375

atc0005 opened this issue Feb 4, 2022 · 0 comments · Fixed by #376
Assignees
@atc0005
Labels
CI enhancement New feature or request linting
Milestone
v0.7.18

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 4, 2022

See atc0005/send2teams#206 for details.
@atc0005 atc0005 added enhancement New feature or request CI linting labels Feb 4, 2022
@atc0005 atc0005 added this to the Next Release milestone Feb 4, 2022
@atc0005 atc0005 self-assigned this Feb 4, 2022
atc0005 added a commit that referenced this issue Feb 7, 2022
@atc0005
Refresh GHAWs: expand linting, switch to GHCR
736e686 
EXPAND LINTING TO USE UNSTABLE & OLDSTABLE CONTAINERS

Use the same matrix of containers for linting in the `Validate
Codebase` GHAW that we're already using for testing and building jobs.

This applies the minimum linting requirements in addition to testing
"unstable" linting options that may become the new baseline in the
future.

One notable difference is that out of the matrix of containers used
for linting we mark the unstable container as "experimental" and
configure the job to ignore linting errors generated by that
container. This effectively makes any linting output from the unstable
container informational only as intended.

SWITCH DOCKER IMAGE SOURCE

Switch out images from Docker Hub to Git Hub Container Registry
(GHCR).

REFERENCES

- GH-374
- GH-375
@atc0005 atc0005 mentioned this issue Feb 7, 2022
Merged
atc0005 added a commit that referenced this issue Feb 7, 2022
@atc0005
Refresh GHAWs: expand linting, switch to GHCR
00089fa 
EXPAND LINTING TO USE UNSTABLE & OLDSTABLE CONTAINERS

Use the same matrix of containers for linting in the `Validate
Codebase` GHAW that we're already using for testing and building jobs.

This applies the minimum linting requirements in addition to testing
"unstable" linting options that may become the new baseline in the
future.

One notable difference is that out of the matrix of containers used
for linting we mark the unstable container as "experimental" and
configure the job to ignore linting errors generated by that
container. This effectively makes any linting output from the unstable
container informational only as intended.

SWITCH DOCKER IMAGE SOURCE

Switch out images from Docker Hub to Git Hub Container Registry
(GHCR).

REFERENCES

- GH-374
- GH-375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
CI enhancement New feature or request linting
Projects
No open projects
Update GitHub Actions Workflows to use GHCR, use oldstable, unstable images for linting
Status: Done
Milestone
v0.7.18
Development

Successfully merging a pull request may close this issue.

Refresh GHAWs: expand linting, switch to GHCR atc0005/elbow
1 participant
@atc0005