Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable go-critic analyzers incompatible with Go 1.18 #575

Closed
atc0005 opened this issue Mar 24, 2022 · 0 comments · Fixed by #579
Closed

Disable go-critic analyzers incompatible with Go 1.18 #575

atc0005 opened this issue Mar 24, 2022 · 0 comments · Fixed by #579
Assignees
@atc0005
Labels
linting unstable
Milestone
v0.6.5

Comments

@atc0005
Copy link
Owner

atc0005 commented Mar 24, 2022

Per golangci/golangci-lint#2649 (comment):

some rules in go-critic (hugeParam, rangeValCopy, typeDefFirst) don't work with generics and must be disabled by hand

refs https://go-critic.com/overview#checks-overview
@atc0005 atc0005 added this to the Next Release milestone Mar 24, 2022
@atc0005 atc0005 self-assigned this Mar 24, 2022
atc0005 added a commit that referenced this issue Mar 25, 2022
@atc0005
Disable incompatible go-critic analyzers
8cb1ccc 
- hugeParam (previously disabled)
- rangeValCopy
- typeDefFirst

refs GH-575
@atc0005 atc0005 mentioned this issue Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
linting unstable
Projects
None yet
Milestone
v0.6.5
Development

Successfully merging a pull request may close this issue.

Disable incompatible go-critic analyzers atc0005/go-ci
1 participant
@atc0005