Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golangci-lint to v1.25.1 #6

Closed
atc0005 opened this issue Apr 23, 2020 · 3 comments
Closed

Update golangci-lint to v1.25.1 #6

atc0005 opened this issue Apr 23, 2020 · 3 comments
Labels
ci golang linting

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 23, 2020 •
edited
Loading

This can be done alongside switching to a stable binary instead of building from master as many (all?) of the CI linting install task runs currently do.
@atc0005
Copy link
Owner Author

atc0005 commented Apr 23, 2020

Pulled from https://github.com/golangci/golangci-lint#install:

This was referenced Apr 23, 2020
Closed
Closed
Closed
Closed
@atc0005 atc0005 changed the title Update golangci-lint to v1.25.0 Update golangci-lint to v1.25.1 Apr 27, 2020
@atc0005
Copy link
Owner Author

atc0005 commented Apr 27, 2020

v1.25.1 released today.

It might be useful if I set the value externally somewhere and have the build process reference that. Perhaps pull a wrapper script from one of my repos instead?

This was referenced Apr 28, 2020
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
@atc0005 atc0005 pinned this issue May 1, 2020
atc0005 added a commit to atc0005/check-mail that referenced this issue May 2, 2020
@atc0005
Update golangci-lint to v1.25.1
a4b339c 
v1.26.0 is out, but I'm trying to get all projects to this
version before rolling out a newer release that I've not
had time to test yet.

refs GH-41
refs atc0005/todo#6
@atc0005 atc0005 mentioned this issue May 2, 2020
Merged
@atc0005 atc0005 unpinned this issue Jun 11, 2020
@atc0005
Copy link
Owner Author

atc0005 commented Jun 23, 2020

Closing in favor of #18.

@atc0005 atc0005 closed this as completed Jun 23, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci golang linting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atc0005