We need out segments for tcp attemptfails :-(

atdt · Jan 3, 2013 · dcd01ec · dcd01ec
1 parent a37c665
commit dcd01ec
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/network/netstats/python_modules/netstats.py b/network/netstats/python_modules/netstats.py
@@ -118,7 +118,7 @@ def get_tcpattemptfail_percentage(name):
     [curr_metrics, last_metrics] = get_metrics()
 
     try:
-      pct = 100 * (float(curr_metrics['data']['tcp']["attemptfails"]) - float(last_metrics["data"]['tcp']["attemptfails"])) / ( float(curr_metrics['data']['tcp']['insegs']) - float(last_metrics['data']['tcp']['insegs']) )
+      pct = 100 * (float(curr_metrics['data']['tcp']["attemptfails"]) - float(last_metrics["data"]['tcp']["attemptfails"])) / (float(curr_metrics['data']['tcp']['outsegs']) +  float(curr_metrics['data']['tcp']['insegs']) - float(last_metrics['data']['tcp']['insegs']) - float(last_metrics['data']['tcp']['outsegs']))
       if pct < 0:
 	print name + " is less 0"
 	pct = 0
@@ -215,7 +215,7 @@ def metric_init(params):
     descriptors.append(create_desc(Desc_Skel, {
 	"name"       : "tcp_attemptfails_percentage",
 	"call_back"  : get_tcpattemptfail_percentage,
-	"description": "TCP attemptfail percentage, tcpattemptfail / insegs",
+	"description": "TCP attemptfail percentage, tcpattemptfail / insegs + outsegs",
 	"units"      : "pct",
         'groups'      : 'tcpext'
 	}))