PMD: AvoidInstantiatingObjectsInLoops

aterai · Jun 17, 2018 · 4338d82 · 4338d82
1 parent 76d8314
commit 4338d82
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/HandDragScrollableTable/src/java/example/MainPanel.java b/HandDragScrollableTable/src/java/example/MainPanel.java
@@ -4,6 +4,7 @@
 // @homepage@
 import java.awt.*;
 import java.awt.event.*;
+import java.util.stream.IntStream;
 import javax.swing.*;
 import javax.swing.table.DefaultTableModel;
 
@@ -17,9 +18,11 @@ private MainPanel() {
                 return getValueAt(0, column).getClass();
             }
         };
-        for (int i = 0; i < 1000; i++) {
-            model.addRow(new Object[] {"aaaaa", i, i % 2 == 0});
-        }
+
+        IntStream.range(0, 1000)
+            .mapToObj(i -> new Object[] {"aaaaa", i, i % 2 == 0})
+            .forEach(model::addRow);
+
         JTable table = new JTable(model) {
             private transient MouseAdapter handler;
             @Override public void updateUI() {

diff --git a/TabWithCloseIcon/src/java/example/MainPanel.java b/TabWithCloseIcon/src/java/example/MainPanel.java
@@ -3,7 +3,7 @@
 // vim:set fileencoding=utf-8:
 // @homepage@
 import java.awt.*;
-import java.util.Arrays;
+import java.util.stream.Stream;
 import javax.swing.*;
 
 public final class MainPanel extends JPanel {
@@ -14,15 +14,16 @@ private MainPanel() {
         JTabbedPaneWithCloseIcons tab2 = new JTabbedPaneWithCloseIcons();
         CloseableTabbedPane tab3 = new CloseableTabbedPane();
 
-        for (JTabbedPane t: Arrays.asList(tab1, tab2, tab3)) {
-            t.addTab("aaa", new JLabel("aaaaaaaa"));
-            t.addTab("bbb", new JLabel("bbbbbbbbb"));
-            t.addTab("c", new JLabel("ccc"));
-            t.addTab("dddd", new JLabel("ddddddd"));
-            add(t);
-        }
+        Stream.of(tab1, tab2, tab3).map(MainPanel::makeTabbedPane).forEach(this::add);
         setPreferredSize(new Dimension(320, 240));
     }
+    private static JTabbedPane makeTabbedPane(JTabbedPane tabbedPane) {
+        tabbedPane.addTab("aaa", new JLabel("aaaaaaaa"));
+        tabbedPane.addTab("bbb", new JLabel("bbbbbbbbb"));
+        tabbedPane.addTab("c", new JLabel("ccc"));
+        tabbedPane.addTab("dddd", new JLabel("ddddddd"));
+        return tabbedPane;
+    }
     public static void main(String... args) {
         EventQueue.invokeLater(new Runnable() {
             @Override public void run() {