-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulator is sorting numbers as strings #262
Comments
I feel I should mention I created this issue a while ago: atesgoral/hrm-level-outbox-generator#1 |
Level 4 should swap entries, not sort them. The other levels need to handle sorts differently for ints and strings because Javascript derp. Fixes atesgoral#1 and atesgoral/hrm-solutions#262
You are correct – I didn't notice the issue or the PR, should have checked over there first. I put in a PR that addresses 4, 28 and 41 before seeing this. |
Level 4 should swap entries, not sort them. The other levels need to handle sorts differently for ints and strings because Javascript derp. Fixes atesgoral#1 and atesgoral/hrm-solutions#262
OMG. I just saw this now. My apologies. |
The simulator is incorrectly showing sort solutions as failing, because it is sorting
10
before2
:One solution is to remove 10 from the test pool. Another is to fix the problem.
The text was updated successfully, but these errors were encountered: