Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds tags merge feature #40

Merged
merged 2 commits into from
Aug 27, 2019
Merged

adds tags merge feature #40

merged 2 commits into from
Aug 27, 2019

Conversation

thlacroix
Copy link
Contributor

Attempt to implement #37

As described in the README, attributes can be merged (+flattened) into the tags attribute by listing them joined by $$$ in the tags GET parameter, eg: tags=environment$$$roles$$$run_list$$$tags.

The $$$ is mainly a placeholder for now, we can discuss here what would be the ideal separator to use. I wanted something with + but these characters looked discarded somehow, so I moved to something else that should not conflict too much with real attribute names.

@thlacroix
Copy link
Contributor Author

Hi @atheiman, what do you think of the change ?

Do you have a preference for the separator ?

@atheiman
Copy link
Owner

Id rather see the syntax in the issue, either of these:

?tags=platform&tags=platform_version
?tags=platform&tags+=platform_version

But looking thru sinatra, I don't see a way to handle GET params specified twice so I think what you're doing is fine.

I'm gonna try to get Travis CI builds on this repo again, I guess they got removed when GitHub switched to the new "Checks" feature

@atheiman
Copy link
Owner

atheiman commented Aug 27, 2019

@thlacroix can you try pushing another commit to see if Travis builds and posts back to this PR?

looks like the last build succeeded in travis, just didnt post back to the PR

@thlacroix
Copy link
Contributor Author

Thanks for your feedback. Indeed the syntax proposed in the issue didn't seem straightforward with sinatra, so I went another way.

I'm not a big fan of the $$$ but I don't have a good replacement idea.

I've re-pushed my commit to trigger travis, looks green.

@atheiman
Copy link
Owner

@thlacroix
Copy link
Contributor Author

Done, version bumped to 1.2.0

@atheiman atheiman merged commit ef78b8a into atheiman:master Aug 27, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants