fix(parser): remove support for underscores so URLs can use

athensresearch · May 16, 2021 · dd5affb · dd5affb
1 parent a81e12e
commit dd5affb
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 40 deletions.
diff --git a/src/cljc/athens/parser/impl.cljc b/src/cljc/athens/parser/impl.cljc
@@ -76,19 +76,13 @@ code-span = <#'(?<!\\w)`'>
             #'(?s)([^`]|(?<=\\s)`(?=\\s))+'
             <#'`(?!\\w)'>
 
-strong-emphasis = (<#'(?<!\\w)\\*\\*(?!\\s)'>
-                   recur
-                   <#'(?<!\\s)\\*\\*(?!\\w)'>)
-                | (<#'(?<!\\w)__(?!\\s)'>
-                   recur
-                   <#'(?<!\\s)__(?!\\w)'>)
-
-emphasis = (<#'(?<!\\w)\\*(?!\\s)'>
-            recur
-            <#'(?<!\\s)\\*(?!\\w)'>)
-         | (<#'(?<!\\w)_(?!\\s)'>
-            recur
-            <#'(?<!\\s)_(?!\\w)'>)
+strong-emphasis = <#'(?<!\\w)\\*\\*(?!\\s)'>
+                  recur
+                  <#'(?<!\\s)\\*\\*(?!\\w)'>
+
+emphasis = <#'(?<!\\w)\\*(?!\\s)'>
+           recur
+           <#'(?<!\\s)\\*(?!\\w)'>
 
 highlight = <#'(?<!\\w)\\^\\^(?!\\s)'>
             recur
@@ -144,10 +138,10 @@ latex = <#'(?<!\\w)\\$\\$(?!\\s)'>
 (* every delimiter used as inline span boundary has to be added below *)
 
 (* anything but special chars *)
-text-run = #'(?:[^\\*_`\\^~\\[!<\\(\\#\\$\\{\\r\\n]|(?<=\\S)[`!\\#\\$\\{])+'
+text-run = #'(?:[^\\*`\\^~\\[!<\\(\\#\\$\\{\\r\\n]|(?<=\\S)[`!\\#\\$\\{])+'
 
 (* any special char *)
-<special-char> = #'(?<!\\w)[\\*_`^~\\[!<\\(\\#\\$\\{]'
+<special-char> = #'(?<!\\w)[\\*`^~\\[!<\\(\\#\\$\\{]'
 
 <backtick> = #'(?<!`)`(?!`)'
 

diff --git a/test/athens/cljs_parser_test.cljs b/test/athens/cljs_parser_test.cljs
@@ -224,16 +224,6 @@
                      [:strong-emphasis
                       [:text-run "strong"]]]
 
-                    "_also emphasis_"
-                    [:paragraph
-                     [:emphasis
-                      [:text-run "also emphasis"]]]
-
-                    "__very strong__"
-                    [:paragraph
-                     [:strong-emphasis
-                      [:text-run "very strong"]]]
-
                     ;; mix and match different emphasis
                     "**bold and *italic***"
                     [:paragraph
@@ -248,11 +238,7 @@
                      [:text-run "normal "]
                      [:emphasis [:text-run "italic"]]
                      [:text-run " "]
-                     [:strong-emphasis [:text-run "bold"]]]
-
-                    "_so wrong*"
-                    [:paragraph
-                     [:text-run "_so wrong*"]]))
+                     [:strong-emphasis [:text-run "bold"]]]))
 
   (t/testing "highlights (local Athens extension `^^...^^`)"
     (util/parses-to sut/inline-parser->ast

diff --git a/test/athens/parser/impl_test.clj b/test/athens/parser/impl_test.clj
@@ -229,16 +229,6 @@
                 [:strong-emphasis
                  [:text-run "strong"]]]
 
-               "_also emphasis_"
-               [:paragraph
-                [:emphasis
-                 [:text-run "also emphasis"]]]
-
-               "__very strong__"
-               [:paragraph
-                [:strong-emphasis
-                 [:text-run "very strong"]]]
-
                ;; mix and match different emphasis
                "**bold and *italic***"
                [:paragraph