Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icons): replace r/create-element with r/adapt-react-class #207

Closed
tangjeff0 opened this issue Jul 2, 2020 · 6 comments · Fixed by #223
Closed

fix(icons): replace r/create-element with r/adapt-react-class #207

tangjeff0 opened this issue Jul 2, 2020 · 6 comments · Fixed by #223
Projects
A Self-Hosted Athens

Comments

@tangjeff0
Copy link
Collaborator

  • no longer need span
  • can pass style directly too as second parameter. see here
@tangjeff0 tangjeff0 created this issue from a note in A Self-Hosted Athens (Good First Issues) Jul 2, 2020
@itsrainingmani
Copy link
Contributor

Hi Jeff,

I've made the changes to icons.cljs on a branch and tested that the icons render on my localhost version of devcards.

Can I submit a PR for this?

@tangjeff0
Copy link
Collaborator Author

tangjeff0 commented Jul 6, 2020 •
edited

@itsrainingmani please first enable GitHub actions and deploy so we can see your demo :)

And no need to ask to submit PRs!

@itsrainingmani
Copy link
Contributor

@tangjeff0 Got the GitHub Actions to work but I don't see the deploy yet. I'm assuming it takes some time the first time around?

@tangjeff0
Copy link
Collaborator Author

@itsrainingmani have to Push again

@itsrainingmani
Copy link
Contributor

@tangjeff0 Ok It's deployed now :). https://itsrainingmani.github.io/athens/cards.html#!/athens.devcards.icons

@tangjeff0
Copy link
Collaborator Author

Submit a PR now!

@itsrainingmani itsrainingmani mentioned this issue Jul 6, 2020
Merged
@tangjeff0 tangjeff0 moved this from Good First Issues to Closed / Archived / Done in A Self-Hosted Athens Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
A Self-Hosted Athens
  
Closed / Archived / Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(icons): replaced r/create-element with r/adapt-react-class itsrainingmani/athens
2 participants
@tangjeff0 @itsrainingmani