-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using :> results in "Cannot convert a Symbol value to a string" #369
Comments
This is because Additionally the |
I'm getting exactly the same behaviour ( Edit Oh goddamnit seems to be a problem with the way shadow-cljs handles |
I think this is not entirely fixed. I just tried to use a |
I have this problems as well, using @material-ui.core. E.g.: (ns wat (:require ["@material-ui/core" :refer [Box]]))
(println (let [children ["a" "b"]]
[:> Box {:p 2} children])) Breaks for me. Changing |
Same for me with @material-ui.core, still unresolved in reagent 0.10.0. It was failing on the following code: (defn tooltip-wrap
"When tooltip is not nil, it wraps the given component with a tooltip."
[component tooltip id]
(if tooltip
[:> Tooltip {:key id
:title tooltip
:arrow true} component]
component))
(for [{:tab/keys [id label tooltip]} tab-list]
(tooltip-wrap [:> Tab {:key id
:label label}] tooltip id)) when for is used within another component. |
#399 is now fixed (in master) so at least Reagent shouldn't try showing those warnings. In case the element really is missing a key, next ClojureScript release will make Symbols printable so the warning will be printed correctly. |
Symbol is printable since Cljs 1.10.741, closing as the Reagent bug that caused bad warning is fixed, and new Cljs will be able to show error messages in proper warning cases. |
Using reagent 0.8.0 & React 16.3.2, I'm trying to leverage React's new context API.
Repro:
package.json:
src/context/core.cljs:
Results in this stack-trace:
Changing to
r/adapt-react-class
makes it work as expected:The text was updated successfully, but these errors were encountered: