Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speedy window re-open on macOS #2016

Merged
merged 2 commits into from Feb 7, 2022
Merged

feat: speedy window re-open on macOS #2016

merged 2 commits into from Feb 7, 2022

Conversation

hyferg
Copy link
Contributor

@hyferg hyferg commented Feb 6, 2022

Normal mac behavior on clicking the red x is to hide the window so it can be opened instantly from the dock and not have to got through the whole initial boot cycle.

You might want to now move the (prevent-save) function onto this close listener so that on macos it can keep syncing in the background since the window is now hidden but not destroyed.

I'd move (prevent-save) to the window "close" event myself but I have no experience using clojure.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2022

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Feb 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/4mGfaCA5DTGEdVkWrmb74GXjw7PT
✅ Preview: https://athens-git-fork-hyferg-hyferg-speedy-reo-0b0f92-athens-research.vercel.app

@filipesilva
Copy link
Collaborator

@hyferg added some more code so that cmq+q still quits and clicking on the dock icon still reopens/shows. The prevent-save fn seems to be fine since it only really runs when the browser window is destroyed, not hidden. Thanks for the contrib, should be in the next release!

@filipesilva filipesilva merged commit db94228 into athensresearch:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants