Fix for issue 2017 hardcoded http backend #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added function to resolve url to perform the healthcheck * Added function resolve the websockets url * Validated fix manually
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/athens-research/athens/GvjvdXH6bDHtfk14hatmaVrh1EN3 |
|
|
|
Fix #2017 |
filipesilva
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first foray into Clojure so I apologize for any newbie errors.
I have two big concerns for this change as is:
resolve-urlandresolve-ws-urlare homed right next to where they are used; should these be added to a "URL utils" type file?