fix(blocks): prevent indent when already a leaf block, prevent indent and unindent when already a top-level child
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt context (athensresearch#209) If the node being unindented is the top-level node in the current context, prevent unindent by checking if parent node id is equal to id present in :current-route object. Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
…#209) A leaf block is a block with block order 0. If the block order is 0, do not indent and return a no-op in the indent event handler Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
…e is no indent or unindent happening (athensresearch#209) Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
tangjeff0
requested changes
Jul 8, 2020
* Move the block zero check in indent event handler to the on-key-down handler since it doesn't require any re-frame or datascript subscriptions * Rename context-root to context-root-uid and remove unnecessary comment in unindent event handler * Use the stricter parent ID to context-root uid check instead of (and parent grandpa) in unindent event handler Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com>
|
Just did a big refactor of blocks, can you resolve conflicts @itsrainingmani ? |
|
Yeah no problem |
…decompose monolith block-el (athensresearch#232) * line 524 of blocks. if I use a dispatch, on-drag-end doesn't get called * feat(blocks): drag and drop PoC for local event handlers. refactor block-el
|
@tangjeff0 Should be able to merge now. |
|
Thanks !! |
korlaism
pushed a commit
to korlaism/athens
that referenced
this pull request
Jul 19, 2021
…ent` and `unindent` when already a top-level child (athensresearch#228) * fix(blocks): prevent unindent when already a top-level child in current context (athensresearch#209) If the node being unindented is the top-level node in the current context, prevent unindent by checking if parent node id is equal to id present in :current-route object. Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * fix(blocks): prevent indent when already a leaf block (athensresearch#209) A leaf block is a block with block order 0. If the block order is 0, do not indent and return a no-op in the indent event handler Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * fix: prevent default browser behavior for tab and shift+tab when there is no indent or unindent happening (athensresearch#209) Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * fix(blocks) - Refactor indent and unindent event handlers * Move the block zero check in indent event handler to the on-key-down handler since it doesn't require any re-frame or datascript subscriptions * Rename context-root to context-root-uid and remove unnecessary comment in unindent event handler * Use the stricter parent ID to context-root uid check instead of (and parent grandpa) in unindent event handler Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> * Add missing devtool devcard deps (athensresearch#229) * feat(blocks): Drag n drop v2. use local listeners instead of global. decompose monolith block-el (athensresearch#232) * line 524 of blocks. if I use a dispatch, on-drag-end doesn't get called * feat(blocks): drag and drop PoC for local event handlers. refactor block-el Co-authored-by: Adrien Lacquemant <github@alaq.io> Co-authored-by: nthd3gr33 <codinginenglish@gmail.com> Co-authored-by: Tom H <git@tomisme.com> Co-authored-by: jeff <tangj1122@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #209 .
There are 3 parts to this fix -
indentevent handler to only perform an indent if the block order for the current block is not 0unindentevent handler to extract theidof the current page from the:current-routeobject ofrfdb. If theidof the current page is equal to the parent ID of the node being unindented, prevent the unindent to keep the node within the current context.Potential Performance Optimization
We wanted to point out that there is some potential performance gain to be had by performing the
ifcheck at the earliest possible moment in the re-frame event handlers and thereby skipping the evaluation of possibly complexletbindings.