Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(right-sidebar): shouldn't flicker on start #238

Merged
merged 3 commits into from Jul 10, 2020
Merged

fix(right-sidebar): shouldn't flicker on start #238

merged 3 commits into from Jul 10, 2020

Conversation

shanberg
Copy link
Collaborator

Demo

Sidebar should no longer appear open-ish for a couple frames before hiding itself.

  • Refactor sidebar toggling to use regular CSS transitions rather than CSS animation, because of difficulty setting the initial state properly.
  • Sidebar should open and close more smoothly now, though it could still be better. Currently it’s using negative margins to slide the content out of the way, and it'd be better if that used a CSS transform, which is allowed to run on the GPU and won't trigger content reflow. That'd be a small optimization though.

@shanberg shanberg changed the title fix(sidebar): sidebar shouldn't glitch open fix(sidebar): sidebar shouldn't the flicker on start Jul 10, 2020
@tangjeff0 tangjeff0 changed the title fix(sidebar): sidebar shouldn't the flicker on start fix(right-sidebar): sidebar shouldn't the flicker on start Jul 10, 2020
@tangjeff0 tangjeff0 changed the title fix(right-sidebar): sidebar shouldn't the flicker on start fix(right-sidebar): shouldn't flicker on start Jul 10, 2020
@tangjeff0 tangjeff0 merged commit 2c64ec0 into athensresearch:master Jul 10, 2020
@tangjeff0 tangjeff0 mentioned this pull request Jul 10, 2020
Closed
2 tasks
@shanberg shanberg deleted the fix-sidebar-peek branch July 14, 2020 01:24
korlaism pushed a commit to korlaism/athens that referenced this pull request Jul 19, 2021
@shanberg @korlaism
fix(right-sidebar): shouldn't flicker on start (athensresearch#238)
9ccbc75 
* fix(sidebar): sidebar shouldn't glitch open

* chore: comment odd features

* chore(sidebar): comment some odd styles

Co-authored-by: shanberg <98312+shanberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangjeff0 tangjeff0 tangjeff0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shanberg @tangjeff0