Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctrl-down and ctrl-up shortcuts to open/close blocks #520

Merged
merged 3 commits into from Dec 29, 2020
Merged

Add ctrl-down and ctrl-up shortcuts to open/close blocks #520

merged 3 commits into from Dec 29, 2020

Conversation

visika
Copy link
Contributor

@visika visika commented Dec 28, 2020

The desired event is triggered, however it is not perfect:
as the block if opened and closed, the editing pointer moves around.
The movement of the pointer should be freezed as an improvement.

visika and others added 3 commits December 28, 2020 11:56
The desired event is triggered, however it is not perfect:
as the block if opened and closed, the editing pointer moves around.
The movement of the pointer should be freezed as an improvement.
@tangjeff0 tangjeff0 marked this pull request as ready for review December 29, 2020 01:56
@tangjeff0
Copy link
Collaborator

Great job @visika. I refactored the cond, then added e preventDefault to stop the cursor from moving unnecessarily. Thank you and congrats on your first contribution!

@tangjeff0 tangjeff0 merged commit 6b636bf into athensresearch:master Dec 29, 2020
@visika
Copy link
Contributor Author

visika commented Dec 29, 2020

Thanks for helping me with this. I noticed that is ctrl + left/right crashes the app unfortunately. I should remedy to this soon.

tangjeff0 added a commit that referenced this pull request Dec 29, 2020
Co-authored-by: jeff <tangj1122@gmail.com>
@visika visika deleted the ctrl-up-down branch December 29, 2020 19:50
korlaism pushed a commit to korlaism/athens that referenced this pull request Jul 19, 2021
korlaism pushed a commit to korlaism/athens that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants