Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(electron): update from 9 to 11 #707

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

tangjeff0
Copy link
Collaborator

@tangjeff0 tangjeff0 commented Feb 27, 2021

resources

Having some trouble here. Keep on getting Unrecognized symbol error seeming to stem from a python file. Tried the patch-package approach and error still exists.

To clarify, the problem is with electron-builder, not electron. There are a few other cross-platform builders for electron that do seem to more up to date.

@tangjeff0 tangjeff0 marked this pull request as draft March 2, 2021 01:21
@tangjeff0
Copy link
Collaborator Author

Seeing if downloading and installing Xcode will make a difference on my M1

@tangjeff0 tangjeff0 added this to Done in 02/28/21 - 03/07/21 Mar 2, 2021
@tangjeff0 tangjeff0 moved this from Done to Needs Review / Blocked in 02/28/21 - 03/07/21 Mar 2, 2021
@sboesen
Copy link
Contributor

sboesen commented Mar 5, 2021

I think the version of electron-builder you tried (22.9.1) does not include the latest mac_alias, see my other comment in #708. 22.10.0+ appears to include the fix for the bug you're seeing on M1, see commit at tag 22.10.0

@tangjeff0
Copy link
Collaborator Author

@sboesen hadn't tried updating builder yet! If someone with an m1 manages to build, I'll split the bounty between you two. If I get to it, I'll just give the bounty to you.

@tangjeff0
Copy link
Collaborator Author

Able to build now! @sboesen

@sboesen
Copy link
Contributor

sboesen commented Mar 5, 2021

@tangjeff0 Great to hear that fix worked!

@tangjeff0
Copy link
Collaborator Author

Do you want to submit to get the bounty for https://gitcoin.co/issue/athensresearch/athens/708/100024940?

@tangjeff0 tangjeff0 marked this pull request as ready for review March 5, 2021 04:49
@tangjeff0 tangjeff0 merged commit 4b506b9 into athensresearch:master Mar 5, 2021
02/28/21 - 03/07/21 automation moved this from Needs Review / Blocked to Done Mar 5, 2021
@tangjeff0 tangjeff0 deleted the update-electron branch March 5, 2021 04:49
@sboesen
Copy link
Contributor

sboesen commented Mar 5, 2021

Thank you - I just marked work as submitted with your commit as a reference. Please let me know if I need to change anything!

@tangjeff0
Copy link
Collaborator Author

Think that's it. Gonna make sure it builds and deploys at https://github.com/athensresearch/athens/runs/2037107204?check_suite_focus=true then will approve.

@tangjeff0
Copy link
Collaborator Author

Looks good!

@tangjeff0 tangjeff0 mentioned this pull request Mar 5, 2021
@sboesen
Copy link
Contributor

sboesen commented Mar 5, 2021

Fantastic, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants