Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): local-graphs and view customization #767

Merged

Conversation

arkRedM
Copy link
Contributor

@arkRedM arkRedM commented Mar 7, 2021

https://www.loom.com/share/b3f16aa7c4084c69b4f47a0e03f7bf65

I am not seeing a perf issue for my current graph, although if it's leading to a bad ux, I can include it in this one or come back to it later.

Added docs based on community call discussion. I think incrementally adding docs from each pr(where code has been added or modified) is better than out-of-context adding of docs.

@arkRedM arkRedM force-pushed the feat/graph-viz-local-customization branch from d152ecf to 4bbf5a3 Compare March 7, 2021 21:34
@arkRedM
Copy link
Contributor Author

arkRedM commented Mar 7, 2021

Strangely my local lint is ignoring with-let(as expected) -- not sure why this is failing here.

@arkRedM arkRedM force-pushed the feat/graph-viz-local-customization branch from 4bbf5a3 to 2c11ee0 Compare March 7, 2021 21:41
@tangjeff0
Copy link
Collaborator

tangjeff0 commented Mar 7, 2021

@arkRedM
Copy link
Contributor Author

arkRedM commented Mar 7, 2021

I think it's only related to lint(clj-kondo). There are no changes in the patch for kondo, could be unrelated?

@tangjeff0 tangjeff0 changed the title feat(graph)/graph viz, local-graphs and view customization feat(graph): graph viz, local-graphs and view customization Mar 7, 2021
@tangjeff0
Copy link
Collaborator

tangjeff0 commented Mar 7, 2021

Taking a look

edit: created an issue ⬇️

@tangjeff0 tangjeff0 changed the title feat(graph): graph viz, local-graphs and view customization feat(graph): local-graphs and view customization Mar 7, 2021
@tangjeff0 tangjeff0 merged commit e015a04 into athensresearch:master Mar 7, 2021
@borkdude
Copy link
Contributor

borkdude commented Mar 7, 2021

Instead of ignoring r/with-let bindings, I suggest adding the config {:lint-as {reagent.core/with-let clojure.core/let}} in .clj-kondo/config.edn.

korlaism pushed a commit to korlaism/athens that referenced this pull request Jul 19, 2021
- adds config, stored in localStorage
- global graph
  - can filter out Daily Notes
  - can filter orphan nodes
  - can config attraction force
  - can config link distance
- local page graph
  - can config `n` hops away
  - can show only root links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants