fix(blocks): links made clickable, z-index clean up #772 #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't seem to work for Linked Refs (or TODOs inside Linked Ref).
|
arkRedM
force-pushed
the
fix/block-embed-z-index-issue
branch
from
7af6c92
to
84978fc
Compare
Hey @tangjeff0 can you check again? I am unable to reproduce this issue. |
|
CACHE IS KING |
|
I don't think clicking TODO/DONE works though. |
korlaism
pushed a commit
to korlaism/athens
that referenced
this pull request
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/3b3d566401eb45a38e8ea63e74c309e2
This issue forced to fix a root issue about how z-index is handled in too many places. This was well buried inside the hierarchy. In the loom, I tried to explain the logic for z-index, textarea and block interactions and can probably act as a reference. Cut down a good amount of hacky code with this 馃槍