Remove custom alias/name for exception class #153
Conversation
mvorisek
requested review from
abbadon1334 and
romaninsh
and removed request for
abbadon1334
|
Added by @abbadon1334 , I don't think it's documented though. Not sure what was the intention. |
mvorisek
force-pushed
the
improve_exception
branch
from
04360b7
to
0181b84
Compare
|
@romaninsh Having custom name in opposite to the real class name is very confusing. I left there custom_exception_title even it seems to be not used acrosss in atk projects. |
mvorisek
force-pushed
the
improve_exception
branch
from
0181b84
to
e05265a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #153 +/- ##
=============================================
- Coverage 97.09% 97.06% -0.04%
+ Complexity 460 456 -4
=============================================
Files 24 24
Lines 1067 1055 -12
=============================================
- Hits 1036 1024 -12
Misses 31 31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Agree with @mvorisek, i don't remember who requested it, but was discussed the ability to set a custom name for Exceptions.
For me there is no problem to remove it.
|
@mvorisek i don't agree or disagree - just wanted to give a chance to @abbadon1334 and hear his reasoning ;) Well done on this PR! |
Plus use "Critical Error" for non-atk exceptions to be consistent with them.
Before:
After:
