Move types to code if possible #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
improve_code_types
branch
3 times, most recently
from
f77bb5e
to
61d48b8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #156 +/- ##
=============================================
- Coverage 97.06% 97.03% -0.03%
+ Complexity 456 448 -8
=============================================
Files 24 24
Lines 1055 1045 -10
=============================================
- Hits 1024 1014 -10
Misses 31 31
Continue to review full report at Codecov.
|
mvorisek
force-pushed
the
improve_code_types
branch
12 times, most recently
from
04211e4
to
0a83ce1
Compare
mvorisek
force-pushed
the
improve_code_types
branch
from
0a83ce1
to
9b25aa1
Compare
mvorisek
force-pushed
the
improve_code_types
branch
from
78c7af0
to
2fec858
Compare
|
Some of the previous commits broke localisation exception tests. Could you see why is it failing? |
romaninsh
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also fixes #154
Forcing
:selfreturn type instead of phpdoc@return $thisis not desired as some IDEs the ignore the phpdoc and usesselfinstead ofstatictype. This will change in PHP 8.0, which will support native return type ofstatic.