Atk4 phpunit polyfill for phpunit < 7.0 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #162 +/- ##
=============================================
- Coverage 97.06% 97.03% -0.03%
+ Complexity 456 448 -8
=============================================
Files 24 24
Lines 1055 1046 -9
=============================================
- Hits 1024 1015 -9
Misses 31 31
Continue to review full report at Codecov.
|
mvorisek
force-pushed
the
make_migration_to_phpunit7_easier
branch
2 times, most recently
from
169d9d1
to
212da48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback welcomed
Tests passing for phpunit = 6.x:
169d9d1 (click the checks icon (red cross) to verify)
Plus polyfill for phpunit < 9.0 for PHP 7.2:
https://github.com/atk4/core/pull/162/files#diff-5e6bff90043b25119e765928c605fc82R72