Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate better names for dyn. methods hooks #207

Merged
merged 2 commits into from
May 19, 2020

Conversation

mvorisek
Copy link
Member

no BC break if the actual names were not used somewhere (i.e. used via the trait iface only)

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #207 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #207   +/-   ##
==========================================
  Coverage      97.09%   97.09%           
- Complexity       450      452    +2     
==========================================
  Files             24       24           
  Lines           1066     1068    +2     
==========================================
+ Hits            1035     1037    +2     
  Misses            31       31           
Impacted Files Coverage Δ Complexity Δ
src/DynamicMethodTrait.php 100.00% <100.00%> (ø) 29.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f854b0b...7d5e34d. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romaninsh romaninsh merged commit 478ec66 into develop May 19, 2020
@romaninsh romaninsh deleted the better_dyn_methods_hook_names branch May 19, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants