Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AtkPhpunit NS and zero memory leaks testing #323

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Rename AtkPhpunit NS and zero memory leaks testing #323

merged 1 commit into from
Jun 22, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek changed the title Purge PHPUnit TestCase Rename AtkPhpunit NS and zero memory leaks testing Jun 21, 2021
@mvorisek mvorisek marked this pull request as ready for review June 21, 2021 19:15
This was referenced Jun 21, 2021
Merged
Merged
abbadon1334
abbadon1334 approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@abbadon1334 abbadon1334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better this way than mine with cycle. Good job as always @mvorisek

@mvorisek mvorisek merged commit 6e19c98 into develop Jun 22, 2021
@mvorisek mvorisek deleted the purge_testcase branch June 22, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbadon1334 abbadon1334 abbadon1334 approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

@georgehristov georgehristov Awaiting requested review from georgehristov

Assignees
No one assigned
Labels
BC-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvorisek @abbadon1334