Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Config Trait #86

Merged
merged 12 commits into from
Feb 25, 2019
Merged

Added Config Trait #86

merged 12 commits into from
Feb 25, 2019

Conversation

DarkSide666
Copy link
Member

@DarkSide666 DarkSide666 commented Feb 24, 2019

ConfigTrait implementation. Mostly useful for using in \atk4\ui\App, but could be used anywhere.

Thanks @gowrav-vishwakarma for initial version of this!

  • Docs missing

@DarkSide666 DarkSide666 changed the title Feature/config trait Added Config Trait Feb 24, 2019
@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #86 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #86      +/-   ##
=============================================
+ Coverage      99.82%   99.84%   +0.01%     
- Complexity       253      276      +23     
=============================================
  Files             12       13       +1     
  Lines            584      631      +47     
=============================================
+ Hits             583      630      +47     
  Misses             1        1
Impacted Files Coverage Δ Complexity Δ
src/ConfigTrait.php 100% <100%> (ø) 23 <23> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32db5dc...2032e09. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it support array in json/ yaml? None in tests. Good addition!

@DarkSide666 DarkSide666 merged commit 29d4cd5 into develop Feb 25, 2019
@DarkSide666 DarkSide666 deleted the feature/config_trait branch February 25, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants