rm empty string to null save typecasting

atk4 · May 28, 2024 · 13ac723 · 13ac723
1 parent 9b7c484
commit 13ac723
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/Persistence.php b/src/Persistence.php
@@ -503,10 +503,6 @@ protected function _typecastSaveField(Field $field, $value)
     {
         $value = $this->_typecastPreField($field, $value, false);
 
-        if (in_array($field->type, ['json', 'object'], true) && $value === '') { // TODO remove later
-            return null;
-        }
-
         // native DBAL DT types have no microseconds support
         if ($value !== null && in_array($field->type, ['datetime', 'date', 'time'], true)
             && str_starts_with(get_class(Type::getType($field->type)), 'Doctrine\DBAL\Types\\')

diff --git a/tests/TypecastingTest.php b/tests/TypecastingTest.php
@@ -206,7 +206,8 @@ public function testEmptyValues(): void
         self::assertNull($mm->get('local-object'));
 
         unset($row['id']);
-        unset($row['local-object']);
+        $row['json'] = null;
+        $row['local-object'] = null;
         $mm->setMulti($row);
 
         self::assertSame($fixEmptyStringForOracleFx(''), $mm->get('string'));