Fix incompatible type matching #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
|
I have added some test-script for typecasting of non-string type's "" into null. The point here is that any non-string type with value of "" is invalid and is probably a null. |
|
Those cases seem to be cleaning up after improper use of casting, so technically we could say those are unnecessary, but create a lot of problems around Agile Data. If those fixes create a problem, please provide examples. |
DarkSide666
reviewed
Oct 12, 2016
| $m['name'] = '4.28'; | ||
| $this->assertEquals([], $m->dirty); | ||
| $m['name'] = '5.28'; | ||
| $this->assertNotEquals([], $m->dirty); |
There was a problem hiding this comment.
why name didn't become dirty here ???
There was a problem hiding this comment.
it did, hence the assertNotEquals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the field value is "4" and you change it to 4 (int) then this makes field dirty. To avoid this, hotfix was added: 33377f7
Unfortunately this resulted in some bad side-effects (not found by tests) reported here: #184 (comment)
This PR is properly addressing the issue, by using strict comparison unless we are dealing with stringified numbers. Also it adds several tests, so if there are more test-cases that are affected, then please add.
The original problem was caused because hasOne('blah', ); will use non-integer fields even for persistence SQL where
idfields use int() by default. Still, we can't be fully sure about that and without typecasting SQL response comes back as string.