Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "asc"/"desc" strings for order direction instead of false/true #626

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Use "asc"/"desc" strings for order direction instead of false/true #626

merged 1 commit into from
Aug 21, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 13, 2020 •
edited
Loading

No description provided.

@mvorisek mvorisek mentioned this pull request Jun 13, 2020
Closed
@mvorisek mvorisek force-pushed the use_consts_for_order_direction branch from 1c12fcc to d385e78 Compare June 15, 2020 17:22
@mvorisek mvorisek force-pushed the use_consts_for_order_direction branch from d385e78 to 392958b Compare July 7, 2020 22:46
@mvorisek mvorisek removed the wontfix label Aug 21, 2020
@mvorisek mvorisek force-pushed the use_consts_for_order_direction branch from 392958b to fd2c22a Compare August 21, 2020 10:39
@mvorisek mvorisek marked this pull request as ready for review August 21, 2020 10:45
georgehristov
georgehristov approved these changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit 765c520 into develop Aug 21, 2020
@mvorisek mvorisek deleted the use_consts_for_order_direction branch August 21, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

Assignees
No one assigned
Labels
BC-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @georgehristov