Fix and test nothing is GET sticky globally #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
6 times, most recently
from
3ff9f65
to
1597000
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
3 times, most recently
from
0e9bb07
to
633ff98
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
9 times, most recently
from
e87bf30
to
f762ac8
Compare
mvorisek
commented
Nov 12, 2021
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
from
04b3d4b
to
d6ed6c3
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
from
9323ed2
to
ee46e42
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
2 times, most recently
from
e0c5b23
to
fc77193
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
from
fc77193
to
0dfffa9
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
2 times, most recently
from
53b677a
to
ed2d55d
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
from
3a2caa2
to
0cf9781
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
3 times, most recently
from
4295161
to
8600f7e
Compare
mvorisek
force-pushed
the
ensure_no_global_sticky
branch
from
645d8ac
to
368a126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No global GET sticky is important design goal of component based atk4/ui and we must fix it and assert it across all tests.
The presented test should reject usages like in #1650 (comment)
Also removing
tools/get-assets.phpas it is dangerous to cache resources as they might become out-of-sync and for some files, such dummy caching is not enought, as the resources might access another resources using relative paths.