Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unimplement JsExpressionable from JsCallback #1955

Merged
merged 7 commits into from
Dec 21, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 20, 2022

View::jsRender() renders jQuery with the view selector, overriding the meaning of the method is wrong and misleading.

fix #1953

related with #1872

@mvorisek mvorisek added BC-break and removed MAJOR labels Dec 21, 2022
@mvorisek mvorisek changed the title Unimplement JsExpressionable from View Unimplement JsExpressionable from JsCallback Dec 21, 2022
@mvorisek mvorisek force-pushed the view_is_not_jsexpressionable branch 5 times, most recently from 04bc72b to 53b82d1 Compare December 21, 2022 13:23
@mvorisek mvorisek marked this pull request as ready for review December 21, 2022 20:41
@mvorisek mvorisek merged commit 975b785 into develop Dec 21, 2022
@mvorisek mvorisek deleted the view_is_not_jsexpressionable branch December 21, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with confirmation modal in latest develop
1 participant