-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move non-View JxXxx classes into Js namespace #1872
Conversation
c7256ad
to
095aa23
Compare
095aa23
to
6ba8250
Compare
18149b9
to
a0f3598
Compare
a0f3598
to
e9a0daf
Compare
7dd464d
to
739c544
Compare
6c6cbb1
to
89939a9
Compare
Hi @mvorisek For clarification: you want to move those Js classes to sub-namespace as they do not return views? How about JsModal or JsToast - they do return views, whereas JQuery etc. surely not. Not sure what the separating line for you is to decide where to place Js classes. Or move all into sub-namespace? |
really? |
JsModal triggers to show a modal and JsToast triggers to show a Toast, so in my understanding this is UI-related, even if this happens on the Js layer. Question was solely, what is the distinction for you what to move to Js - if all Js classes, fine; if only non-view related then this might get confusing. |
changed title from |
Fine for me 👍 |
regex for renamespaced classes: