Move non-View JxXxx classes into Js namespace #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
reorg_js_classes
branch
4 times, most recently
from
c7256ad
to
095aa23
Compare
mvorisek
force-pushed
the
reorg_js_classes
branch
from
095aa23
to
6ba8250
Compare
mvorisek
requested review from
mkrecek234,
georgehristov,
abbadon1334 and
DarkSide666
mvorisek
force-pushed
the
reorg_js_classes
branch
from
18149b9
to
a0f3598
Compare
mvorisek
force-pushed
the
reorg_js_classes
branch
from
a0f3598
to
e9a0daf
Compare
mvorisek
force-pushed
the
reorg_js_classes
branch
from
7dd464d
to
739c544
Compare
mvorisek
force-pushed
the
reorg_js_classes
branch
from
6c6cbb1
to
89939a9
Compare
mvorisek
removed request for
DarkSide666,
abbadon1334,
georgehristov and
mkrecek234
|
Hi @mvorisek For clarification: you want to move those Js classes to sub-namespace as they do not return views? How about JsModal or JsToast - they do return views, whereas JQuery etc. surely not. Not sure what the separating line for you is to decide where to place Js classes. Or move all into sub-namespace? |
really? |
|
JsModal triggers to show a modal and JsToast triggers to show a Toast, so in my understanding this is UI-related, even if this happens on the Js layer. Question was solely, what is the distinction for you what to move to Js - if all Js classes, fine; if only non-view related then this might get confusing. |
mvorisek
changed the title
|
changed title from |
|
Fine for me 👍 |
mkrecek234
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regex for renamespaced classes: