Drop unused App portals code #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Sep 10, 2023
| private function getRenderedPortals(): array | ||
| { | ||
| // prevent looping (calling App::terminateJson() recursively) if JsReload is used in Modal | ||
| unset($_GET['__atk_reload']); |
There was a problem hiding this comment.
This PR does not replace this unset in any way, but it should be no longer needed, as tested since it was introduced in #1374.
mvorisek
force-pushed
the
drop_app_portals_code
branch
from
4356dd3
to
f310783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App portals objects are not stored since #1771