Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Modal Element reload #1374

Merged
merged 3 commits into from
Jul 22, 2020
Merged

[fix] Modal Element reload #1374

merged 3 commits into from
Jul 22, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Jul 21, 2020

Fix issue when an element inside a modal needs to be reloaded.
This fix will prevent the View::getHtml() method to run into an infinite loop.

@ibelar ibelar requested a review from mvorisek July 21, 2020 19:04
src/View.php Outdated Show resolved Hide resolved
mvorisek and others added 2 commits July 21, 2020 23:56
- Modify FeatureContext in order to test locally without dump.
Copy link
Member

@mvorisek mvorisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, fix fixes and test tests the original issue

@ibelar ibelar merged commit 2488f95 into develop Jul 22, 2020
@ibelar ibelar deleted the fix/modal-element-reloading branch July 22, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants