Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to check for $cdn existance #244

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

DarkSide666
Copy link
Member

  • no need to check for $cdn == false here. isset() will do the same.
  • add some comments

@codecov
Copy link

codecov bot commented Oct 19, 2017

Codecov Report

Merging #244 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #244   +/-   ##
=========================================
  Coverage       73.7%   73.7%           
+ Complexity      1051    1046    -5     
=========================================
  Files             58      58           
  Lines           2514    2514           
=========================================
  Hits            1853    1853           
  Misses           661     661
Impacted Files Coverage Δ Complexity Δ
src/App.php 75.55% <100%> (ø) 93 <0> (-5) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808d5ae...ba6f815. Read the comment docs.

@romaninsh romaninsh merged commit 6cd5447 into develop Oct 19, 2017
@romaninsh romaninsh deleted the feature/useless-condition branch October 19, 2017 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants