Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/ set input attribute to readonly or disable. #576

Merged
merged 10 commits into from
Oct 12, 2018
Merged

fix/ set input attribute to readonly or disable. #576

merged 10 commits into from
Oct 12, 2018

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Oct 8, 2018

Add two new attribute to input tag: readonly and disabled

fixes: #575

screen shot 2018-10-08 at 5 43 20 pm

Use:

$f = $app->add(new \atk4\ui\Form('segment'));

$f->addField('readonly', ['readonly' => true])->set('read only');
$f->addField('disabled', [ 'disabled' => true])->set('disabled');

@ibelar ibelar changed the title feature/ set input attribute to readonly or disable. fix/ set input attribute to readonly or disable. Oct 8, 2018
romaninsh
romaninsh requested changes Oct 8, 2018
View reviewed changes
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need documentation and examples

romaninsh
romaninsh reviewed Oct 8, 2018
View reviewed changes
src/FormField/Input.php Outdated
@@ -24,6 +24,9 @@ class Input extends Generic

public $iconLeft = null;

public $disabled = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php doc needed /**

@DarkSide666 DarkSide666 self-requested a review October 9, 2018 10:49
@DarkSide666 DarkSide666 self-assigned this Oct 9, 2018
DarkSide666 and others added 8 commits October 9, 2018 14:50
@DarkSide666
slightly change implementation and add demo
484b067
@romaninsh @StyleCIBot
Apply fixes from StyleCI
c90bff9
@DarkSide666
add docs
21e9b8b
@ibelar
fix disable - readonly
8569597 
fix for checkbox, radio, dropdown, file upload, lookup fields
@romaninsh @StyleCIBot
Apply fixes from StyleCI
1391377
@DarkSide666
fix few bugs
7f8f15c
@ibelar
minor fix
7fd794b 
prevents autocomplete and lookup to have tab enable when readonly or disabled.
Fix Calendar input when readonly.
@DarkSide666
don't even try to save not editable field values
02f629c
romaninsh
romaninsh approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's some useful work done thene!!

@DarkSide666 DarkSide666 merged commit da40dd2 into develop Oct 12, 2018
@DarkSide666 DarkSide666 deleted the feature/input-readonly-disabled branch October 12, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaninsh romaninsh romaninsh approved these changes

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees

@DarkSide666 DarkSide666

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled fields can still be focused and edited
3 participants
@ibelar @romaninsh @DarkSide666