Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Telefónica Network API extension + minor bugfixes and enhancements #7

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ajsanchez
Copy link

Hi!

I've added two new modules ("tef" and "network") to support Telefonica Network API extension (documented at https://api-eu-lon-1.instantservers.telefonica.com/docs/networkapi_docs.html or any other endpoint) on top of SDC 6.5.

I've moved the TELEFONICA_LOCATIONS from "datacenter" to "tef", and added the ACENS_LOCATIONS, which is a Telefónica company selling the service at Spain (so endpoints are different).

Also, some bugfixes and enhancements (for example, properly parsing "Content-Type: application/json; charset=xxx").

Regards. --AJ

@atl
Copy link
Owner

atl commented Jun 28, 2013

Thanks, AJ!

I'll need to take a closer look (hopefully this weekend), but I'm really excited to hear about the new endpoints.

@ajsanchez
Copy link
Author

Actually, I am not in a hurry: today I am beginning my holidays, so I'll be
out for the next week.

If you plan to test out the new modules, please:

  • Turn the SSL verification off for the Acens endpoints (assuming you have
    an account from them), as they managed to certify the "my.instantservers.es"
    domain but not the "api-xxx.instantservers.es".
  • Note the get/set_inbound_rule_status() are not working, as the GET/PUT
    /:login/network/:id/inbound/:rule_id requests are always failing with a 404
    error (interestingly, the DELETE ones succeed!). I've already notified the
    problem, as you can turn on/off rules on the web portal!

BTW, the only way I've managed to validate my private key against the SDC
endpoints is using allow_agent=True... I think that's because of the way I
generated it, but not really sure!

Best regards. --AJ

2013/6/28 Adam Lindsay notifications@github.com

Thanks, AJ!

I'll need to take a closer look (hopefully this weekend), but I'm really
excited to hear about the new endpoints.


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-20215389
.

@ajsanchez
Copy link
Author

Hi, Adam.

Did you find some time to review this pull request?

Regards. --AJ

2013/6/28 Antonio J. dodvan@gmail.com

Actually, I am not in a hurry: today I am beginning my holidays, so I'll
be out for the next week.

If you plan to test out the new modules, please:

  • Turn the SSL verification off for the Acens endpoints (assuming you have
    an account from them), as they managed to certify the "
    my.instantservers.es" domain but not the "api-xxx.instantservers.es".
  • Note the get/set_inbound_rule_status() are not working, as the GET/PUT
    /:login/network/:id/inbound/:rule_id requests are always failing with a 404
    error (interestingly, the DELETE ones succeed!). I've already notified the
    problem, as you can turn on/off rules on the web portal!

BTW, the only way I've managed to validate my private key against the SDC
endpoints is using allow_agent=True... I think that's because of the way I
generated it, but not really sure!

In case you haven't noticed yet, I work as a Product Manager at Telefónica
Digital for the Instant Servers service, and we plan to further extend the
private networks in next weeks (tip: VPNs).

Best regards. --AJ

2013/6/28 Adam Lindsay notifications@github.com

Thanks, AJ!

I'll need to take a closer look (hopefully this weekend), but I'm really
excited to hear about the new endpoints.


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-20215389
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants