forked from apache/atlas
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of restrictPropagationThroughHierarchy flag in classification propagation #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictThroughLineage was being passed, and handled the edge case of both flag being true. Added the concept of toExclude for flag basis getting of labels.
Added a method to test propagation config before sending it to BG task queue.
…rarchy:True) for API /bulk with replaceClassification route flag
nikhilbonte21
requested changes
Mar 27, 2024
common/src/main/java/org/apache/atlas/repository/Constants.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityComparator.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Outdated
Show resolved
Hide resolved
...itory/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java
Outdated
Show resolved
Hide resolved
nikhilbonte21
requested changes
Mar 27, 2024
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Outdated
Show resolved
Hide resolved
checkaayush
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
nikhilbonte21
approved these changes
Apr 1, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Type of change
Related issues
Checklists
Development
Security
Code review