Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of restrictPropagationThroughHierarchy flag in classification propagation #2891

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Mar 26, 2024

Change description

Currently when a tag is propagated, it can be propagated to via a couple of paths
Via hierarchy
Via lineage

When it comes to configure & customize these propagation paths, we only support restricting though lineage with restrictPropagationThroughLineage flag. This means propagations via hierarchy are not optional & done forcefully even when not required.

To make it optional, we have introduced another flag which help to control propagations via hierarchy : restrictPropagationThroughHierarchy
Added Argument of restrictThroughHierarchy in all methods where restrictThroughLineage was being passed, and handled the edge case of both flag being true. Added the concept of toExclude for : flag basis getting of labels.
Handled all test cases and made fixes for them.
Added a method to test propagation config before sending it to Background task queue.

Type of change

  • [] New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

…ictThroughLineage was being passed, and handled the edge case of both flag being true. Added the concept of toExclude for flag basis getting of labels.
Added a method to test propagation config before sending it to BG task queue.
…rarchy:True) for API /bulk with replaceClassification route flag
Copy link
Collaborator

@checkaayush checkaayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@checkaayush checkaayush merged commit b014b40 into master Apr 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants