Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix restriction on prop via lineage #3074

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

sumandas0
Copy link

Wrong propagation mode selected even though propagation through lineage was disabled

One silly mistake led to selecting wrong propagation mode which was leading to propagation to downstream assets even though we were restricting it. This regression was due to. #2891

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix [https://github.com//pull/2891](Addition of restrictPropagationThroughHierarchy flag in classification propagation)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@sumandas0 sumandas0 merged commit 0ba26d9 into master May 13, 2024
7 checks passed
@sumandas0 sumandas0 deleted the fix-prop-through-lineage branch May 16, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants