Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping updates #321

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Housekeeping updates #321

merged 8 commits into from
Aug 21, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Aug 21, 2024

Addresses the test breakage in #319, and some other things:

  • Use flit as the build backend for sdx-controller, similar to Use flit datamodel#146 and Use flit pce#216.
  • Drop Python 3.8 from test matrix, and add Python 3.12 to test matrix.
  • Add Italo to author's list.
  • Add a .mailmap file so that git log etc will print the correct thing.
  • Update Dockerfile and hadolint check now that we're not using setuptools_scm anymore.
  • Use pce@3.0.0.dev0 as the dependency, not pce@main.

@coveralls
Copy link

coveralls commented Aug 21, 2024

Pull Request Test Coverage Report for Build 10493583864

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 58.211%

Totals Coverage Status
Change from base Build 10473608051: 0.3%
Covered Lines: 1038
Relevant Lines: 1847

💛 - Coveralls

Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so many email for Cong in .mailmap?

@congwang09
Copy link
Contributor

congwang09 commented Aug 21, 2024

why so many email for Cong in .mailmap?

Yeah true. Some of my laptops have different hostnames when moving around different networks. Also I committed some changes from the sdx RENCI testbed VM. But those are not real email addresses. Only @renci.org one is the right email address. @sajith should we only keep the email address?

@sajith
Copy link
Member Author

sajith commented Aug 21, 2024

The .mailmap is there so that git log and git shortlog will show Cong Wang <cwang@renci.org> instead of C <cong@Cs-MacBook-Air.attlocal.net> etc. Since we can't rewrite git history, I think this is helpful.

@sajith sajith merged commit 305ecd8 into main Aug 21, 2024
11 checks passed
@sajith sajith deleted the use-flit branch August 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants