Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues with web UI #145

Merged
merged 6 commits into from Mar 30, 2023
Merged

Address issues with web UI #145

merged 6 commits into from Mar 30, 2023

Conversation

fabianishere
Copy link
Member

Summary

This pull request addresses several issues that have been reported for the OpenDC web UI.

Implementation Notes ⚒️

  • Update dependencies for web UI
  • Inform user when deleted topology is still used
  • Do not offset hover layer after dragging
  • Fix access to machines on lower shelves
  • Do not allow selection of empty unit
  • Fix rack deletion

Fixes #135, #136, #137, #138, #139

@fabianishere
build(web): Update dependencies for web UI
6bc9b99 
This change updates the dependencies for the web UI to the latest
available version where possible.
@fabianishere
bug(web): Inform user when deleted topology is still used
a9da766 
This change fixes #135 which showed that trying to delete a topology
used by a scenario would result in nothing happening in the UI and a 500
error being returned by the server. We check whether a scenario still
references the topology and show an error to the user if that happens.

Fixes #135
@fabianishere fabianishere added kind/bug Something isn't working area/web Changes related to OpenDC web components labels Mar 27, 2023
@fabianishere fabianishere self-assigned this Mar 27, 2023
This was linked to issues Mar 27, 2023
New floor selection offset from cursor when dragging #136
Closed
Unable to create machines on lower shelves on rack without populating higher ones #137
Closed
UI disappears when adding CPU/Memory without selecting a unit #138
Closed
Unable to delete rack from floor plan #139
Closed
@fabianishere
bug(web): Do not offset hover layer after dragging
efe1ceb 
This change fixes #136 which reported that the grid and cursor will fall
out of sync when dragging or moving the grid when placing rooms or
objects.

Fixes #136
@fabianishere
bug(web): Fix access to machines on lower shelves
760cb36 
This change addresses #137 which reports that machines on shelves lower
than the top shelve cannot be accessed and doing so will cause the UI to
disappear and an error message to be generated.

The issue was caused by using the incorrect logic for selecting the
machine at a certain rack position.

Fixes #137
@fabianishere
bug(web): Do not allow selection of empty unit
42caec3 
This change fixes #138 which reports that when adding a unit to a
machine, if the user does not select a unit and presses add, the UI will
crash. We now disable the add button until the user has selected a unit.
@fabianishere
bug(web): Fix rack deletion
e7d5c08 
This change fixes #139 which reports that racks cannot be deleted. This
was due to the tileId property being dropped in the backend for racks.
Instead, we use the tileId passed in the action directly.
@fabianishere fabianishere merged commit 0db9d47 into master Mar 30, 2023
7 checks passed
@fabianishere fabianishere deleted the bug/web-ui branch March 30, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianishere fabianishere

Labels
area/web Changes related to OpenDC web components kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@fabianishere