mode/bookmarklets: Check if javascript: url is percent-encoded.

atlas-engineer · Aug 23, 2023 · 260de32 · 260de32
1 parent b9e85ad
commit 260de32
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/source/mode/bookmarklets.lisp b/source/mode/bookmarklets.lisp
@@ -28,7 +28,12 @@ By default, this mode does nothing but expose the default bookmarklet commands."
                              (pathname (files:content (make-instance 'files:file :base-path source)))
                              (string source)))
                    (source (if (str:starts-with-p "javascript:" source)
-                               (quri:url-decode (subseq source 11))
+                               (let ((source-original (subseq source 11)))
+                                 (if (string= source-original (quri:url-decode source-original))
+                                     source-original
+                                     (progn
+                                       (echo-warning "Bookmarklet is not properly percent-encoded.")
+                                       "")))
                                source)))
               (ffi-buffer-evaluate-javascript-async buffer source))))
     (export 'define-bookmarklet-command)