Add iframe support for hint-mode

[Ambrevar]

Hinting on the duckduckgo iframe at https://nyxt.atlas.engineer/start does not work.

[Ambrevar]

@aartaka You merged some work on iframes recently, any chance it fixes this?

[aartaka]

@aartaka You merged some work on iframes recently, any chance it fixes this?

No, the iframe work I've done was purely request-related. For this issue, the fix should be something close to the #1828 fix (which I started but haven't yet finished implementing).

[Ambrevar]

Label as dom?

[aadcg]

I don't think this is important to solve by 3.0.

[Ambrevar]

Agreed.

[aartaka]

It is inoortant! As important as #1828! We need our keyboard interfaces to work as good as mouse for Nyxt to be good enough of keyboard-driven browser. For that, we should make hints work in iframes and Shadow DOM, because more and more websites use the latter, while lots already rely of the former ヽ(ｏ`皿′ｏ)ﾉ

[aadcg]

I agree it's important, but I can't commit to it when there are more pressing issues.

[Ambrevar]

Would it be API-breaking to fix it after the 3.0 release?

[aadcg]

I would say it is not.

[aartaka]

Closing this as not planned after some analysis of IFrame behaviors.

[aadcg]

I don't think iframe hinting is impossible for all cases as Saka key seems to be able to support it.

This is not a priority, but maybe we should keep this issue open for future reference. CC @jmercouris.

[jmercouris]

Interesting, I wonder how that works...

[aadcg]

It would involve studying https://github.com/lusakasa/saka-key/blob/master/src/modes/hints/client/findHints.js#L24.