IFrame hinting #2821
Closed
IFrame hinting #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you'd like a pre-review. |
FIXME: Hint mode and other functionality is not yet iframe-aware, because the hint creation is not descending into iframes.
Now it should accept JS-side data too.
This commit is questionable, because: - It makes processing strictly per-element, because our define-parenscript functions don't allow any Lisp-side processing (a high time we had one). Per-element processing may result in longer drawing and hint processing time. - The whole infrastructure for hints takes documents now, to cope with multi-document structure of documents with iframes (where documents beyond the default one are iframe-resident ones).
Because all engines forbid it.
|
After some thought and tinkering with this features, I'm sure it needs to be dropped. IFrames are not intended for hinting, because:
Which means: most IFrames one encounters in the wild are absolutely un-hintable, and those that are hintable make no sense anyway. Closing this as meaningless. |
7 tasks
|
@aartaka ok to delete this branch? |
|
aartaka ok to delete this branch?
Off with its head!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a huge work-in-progress to finally allow iframes in hints. Only the foundations are implemented, like parsing iframes (done before this PR in cf2a7bf and adjacent commits) and allowing nested search for Nyxt DOM nodes.
Fixes #1526.
Discussion
Don't review yet, it's neither complete nor working :D
Checklist:
Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.
cd /path/to/nyxt/checkout git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser:documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)changelog.lispwith my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).migration.lispentry for all compatibility-breaking changes.