Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage cl-tld to validate domains #1876

Closed
Ambrevar opened this issue Nov 17, 2021 · 6 comments
Closed

Leverage cl-tld to validate domains #1876

Ambrevar opened this issue Nov 17, 2021 · 6 comments
Labels
feature Feature requests. good-first-issue Marks a good issue for first-time contributors.

Comments

@Ambrevar
Copy link
Member

Ambrevar commented Nov 17, 2021

In particular in input->queries and valid-url-p to get more precise URL / domain validation without expensive system calls.

https://github.com/lu4nx/cl-tld

UPDATE: Fix typo.

@Ambrevar Ambrevar added good-first-issue Marks a good issue for first-time contributors. feature Feature requests. labels Nov 17, 2021
@guojing0
Copy link
Contributor

This seems interesting; I will look into it.

Do you mean "to get more precise URL ..."?

@Ambrevar
Copy link
Member Author

Indeed! :)

@hendursaga
Copy link
Contributor

If/when this gets finished, it might be a good idea to request adding Nyxt to the Public Suffix projects' list.

@hendursaga
Copy link
Contributor

I'm not sure how to assign myself, but I'm working on this right now. @Ambrevar when you say "without expensive system calls" are you meaning to search for and remove the check-dns-p logic, or at least set it to NIL by default, in arguments?

@Ambrevar
Copy link
Member Author

Ambrevar commented Feb 5, 2022 via email

@aadcg
Copy link
Member

aadcg commented Mar 11, 2024

Done in #2081.

@aadcg aadcg closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests. good-first-issue Marks a good issue for first-time contributors.
Development

No branches or pull requests

4 participants