-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage cl-tld to validate domains #1876
Comments
This seems interesting; I will look into it. Do you mean "to get more precise URL ..."? |
Indeed! :) |
If/when this gets finished, it might be a good idea to request adding Nyxt to the Public Suffix projects' list. |
I'm not sure how to assign myself, but I'm working on this right now. @Ambrevar when you say "without expensive system calls" are you meaning to search for and remove the |
Something like that, yes.
`check-dns-p` would still be useful because it would check for valid
domains, while cl-tld only allows to check for valid tlds, which is more
limited.
So we would proceed like we do now:
- 1st pass: syntax check using cl-tld.
This yields a bunch of prompt buffer suggestions, possibly with false positives.
- 2nd pass: DNS checks to filter out the false positives.
|
Done in #2081. |
In particular in
input->queries
andvalid-url-p
to get more precise URL / domain validation without expensive system calls.https://github.com/lu4nx/cl-tld
UPDATE: Fix typo.
The text was updated successfully, but these errors were encountered: