Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get-unique-selector instead of Nyxt IDs #2952

Open
aartaka opened this issue May 9, 2023 · 0 comments
Open

Use get-unique-selector instead of Nyxt IDs #2952

aartaka opened this issue May 9, 2023 · 0 comments
Labels
dom Related to DOM: element hints, visual mode and others. feature Feature requests. hint-mode privacy

Comments

@aartaka
Copy link
Contributor

aartaka commented May 9, 2023

Is your feature request related to a problem? Please describe.
Our current nyxt-identifier-reliant page interaction model is quite shaky and not-exactly-privacy-preserving.

Describe the solution you'd like
An alternative technique that I've been drafting and the prototype of which is already in nyxt/dom: get-unique-selector. Computing the unique for the element is:

  • Possible.
  • Resilient to minor page modifications.
  • And privacy-preserving (no Nyxt-specific DOM modifications).

Describe alternatives you've considered
Possibly reuse WebKit APIs for DOM (but these are extension-specific and deprecated in latest versions?)

Additional context
See 9cabd48#commitcomment-112564009 for the initial discussion.
finder can be an inspiration and a template for a complete implementation.

@aartaka aartaka added privacy feature Feature requests. dom Related to DOM: element hints, visual mode and others. hint-mode labels May 9, 2023
aartaka added a commit that referenced this issue May 9, 2023
See #2952 for how it's planned to evolve until it's exported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dom Related to DOM: element hints, visual mode and others. feature Feature requests. hint-mode privacy
Development

No branches or pull requests

1 participant