Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent mouse scroll wheel behavior on hover depending on buffer type #3111

Open
aadcg opened this issue Aug 1, 2023 · 9 comments
Open
Labels
low prompt-buffer Related to the prompt buffer. ui/ux Nyxt User Interface: themes, appearance and usability.

Comments

@aadcg
Copy link
Member

aadcg commented Aug 1, 2023

When hovering over the main or panel buffers, mouse scrolls are intercepted in the hovered buffer.

When the prompt buffer is open, mouse scrolls are intercepted exclusively by the prompt buffer.

The behavior is illustrated below.

simplescreenrecorder-2023-08-01_18.48.41.mp4

This seems to contradict the behaviour most users expect.

When the prompt buffer is open and the mouse hovers over a non prompt buffer area, I'd suggest either no scrolling or scrolling the buffer that is being hovered.

When the prompt buffer is open and the mouse hover over it, it should scroll it.

@aadcg aadcg added low prompt-buffer Related to the prompt buffer. ui/ux Nyxt User Interface: themes, appearance and usability. labels Aug 1, 2023
@lansingthomas
Copy link
Contributor

Eeeeeew a bug

@lansingthomas
Copy link
Contributor

lansingthomas commented Aug 14, 2023

Soo... just thinking out loud here.

If we set the input-focus to follow mouse pointer hover position,

  • then this scrolling problem is fixed, as well as a few other problems (like trying to run quit-prompt-buffer when focus is on the main buffer).
  • however, we introduce another problem (opening prompt buffer with mouse pointer on the upper half of the screen would change input to main buffer at the wrong time)

Sooo... Can we set the input-focus to follow the mouse pointer -- AFTER a transition has been made (from main-buffer to prompt-buffer, but not the other way.)

@lansingthomas
Copy link
Contributor

Like this:
a mouse cursor transition from mainbpromptb | toggle-buffer-focus
a mouse cursor transition from promptbmainb | no action (a click is still required)

@aadcg
Copy link
Member Author

aadcg commented Aug 14, 2023

@lansingthomas think about the user. You suggestion feels overly complicated for no good reason. Generally speaking, setting the focus without a mouse click is rather unintuitive and not a good default.

On the other hand, people expect to interact, i.e. scroll, with the thing that they're pointing to.

Think about the text box from where you'll be writing a reply to my message. Hover over the box - it scrolls the message. Hover outside the text box - it scrolls the issue's page. Focus on hover is orthogonal to this discussion.

From my top post:

When the prompt buffer is open and the mouse hovers over a non prompt buffer area, I'd suggest either no scrolling or scrolling the buffer that is being hovered.

I think it's clear what my choice would be :)

@lansingthomas
Copy link
Contributor

Makes sense.

I want what you propose:
scroll the buffer being hovered!

@lansingthomas
Copy link
Contributor

@aartaka look! the thing we talked about already has an open issue. I totally forgot about this... and made a new video describing the bug.

@lansingthomas
Copy link
Contributor

scroll-buffer-up-down.mp4

@aartaka
Copy link
Contributor

aartaka commented Nov 28, 2023

Scroll on hover is hard, because GTK treats the view with focused input (which prompt buffer is) as the highest priority one. So we either focus out of prompt buffer (by clicking on main buffer or elsewhere), or do some infernal magic to unfocus on hover.

@aadcg
Copy link
Member Author

aadcg commented Nov 28, 2023

With regards to focus, there seems to be deeper issues so this one can only be addressed after #1463 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low prompt-buffer Related to the prompt buffer. ui/ux Nyxt User Interface: themes, appearance and usability.
Development

No branches or pull requests

3 participants