Delete Commands

[jmercouris]

After reviewing all Nyxt commands, I believe the following should be deleted:

• clean-configuration
• copy-placeholder
• enable-hook-handler (see Refactor {enable,disable}-hook-handler commands. #3310)
• disable-hook-handler (see Refactor {enable,disable}-hook-handler commands. #3310)
• duplicate-buffer
• duplicate-buffer-with-current-modes
• follow-hint-with-current-modes-new-buffer
• go-up
• history-forwards-query
• load-file
• nyxt-init-time
• print-bindings
• reload-buffer
• reload-with-modes
• resume-prompt
• set-action-on-current-suggestion
• save-input-data
• set-input-data-from-saved
• set-input-data-from-saved-domain

[jmercouris]

Are there any reasons not to delete them?

[aadcg]

In my view, some of these commands should be demoted to functions:

• clean-configuration
• enable-hook-handler
• disable-hook-handler

---

History commands

From all history commands below you suggest deleting history-forwards-query alone. What motivates this choice?

• history-forwards
• history-backwards-query
• history-forwards-direct-children
• history-forwards-maybe-query
• history-forwards-query
• history-forwards-all-query
• history-all-owner-nodes-query
• history-all-query
• buffer-history-tree

---

load-file

What motivates your view? The fact that we have load-config-file and load-file is too general? Right now, I believe it should stay.

---

nyxt-init-time

I believe it should stay. Nyxt users value tweaking their systems so it seems useful.

---

set-action-on-current-suggestion

If we delete this command, then the user isn't able to set it dynamically. I think it should stay. At least until we change the prompt buffer UI/UX with regards to actions (if we ever do).

---

@jmercouris I've edited your top post.

I can do it once we reach a decision.

[aadcg]

@jmercouris mode record-input-field-mode defines 3 commands, and all have been marked for deletion. I took a cursory look and I'd suggest deleting the mode completely. I don't think it's a core feature.

@jmercouris you marked go-up for deletion. What about go-to-homepage, go-next and go-previous?

[jmercouris]

Firstly. I am OK with all of your suggestions about what not to delete that you've listed above.

With regards to record-input-field-mode, yes, we can fully delete it.

With regards to go-up, go-next et al., the problem is that it works on so /few/ pages, and thus presents to the user a degraded experience. If we could generalize it for websites that do not support this pattern, or provide the user with a helpful message, we could leave them in.