Delete modes and commands #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmercouris
reviewed
Jan 15, 2024
jmercouris
reviewed
Jan 15, 2024
| @@ -169,35 +169,6 @@ Important pieces of functionality are: | |||
| "Scroll to top if no input element is active, forward event otherwise." | |||
| (call-non-input-command-or-forward #'scroll-to-top :buffer buffer)) | |||
|
|
|||
There was a problem hiding this comment.
I see you deleted all of the go-* functions. Yes, why not. I don't think anyone will miss them. Plus they need some reworking to consider /all/ cases, to be more reliable.
There was a problem hiding this comment.
go-to-homepage and go-up aren't hard to get right so heuristics would be needed. Should do engage in such endeavors when we have so many concrete and properly defined issues at hand? Probably not.
go-next and go-previous seemed to misbehave. I tried them out and a JS warning was raised if I'm not mistaken.
jmercouris
approved these changes
Jan 15, 2024
The functionality isn't paramount.
The way the mode implements the feature is subpar.
aadcg
force-pushed
the
delete-modes-and-commands
branch
from
cdf1fd5
to
81a9ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1633
Fixes #3297
Checklist:
(asdf:test-system :nyxt/gi-gtk))